From: Julia Lawall Date: Fri, 1 May 2015 19:37:57 +0000 (+0200) Subject: staging: lustre: lov: lov_dev: remove unneeded null test before free X-Git-Tag: v4.2-rc1~88^2~933 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=34b8fbd6cdb1251d7f2bb3645124148365c5089a;p=platform%2Fkernel%2Flinux-exynos.git staging: lustre: lov: lov_dev: remove unneeded null test before free Kfree can cope with a null argument, so drop null tests. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression ptr; @@ - if (ptr != NULL) kfree(ptr); // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/lov/lov_dev.c b/drivers/staging/lustre/lustre/lov/lov_dev.c index 63db87a..504b24a 100644 --- a/drivers/staging/lustre/lustre/lov/lov_dev.c +++ b/drivers/staging/lustre/lustre/lov/lov_dev.c @@ -298,8 +298,7 @@ static struct lu_device *lov_device_free(const struct lu_env *env, const int nr = ld->ld_target_nr; cl_device_fini(lu2cl_dev(d)); - if (ld->ld_target != NULL) - kfree(ld->ld_target); + kfree(ld->ld_target); if (ld->ld_emrg != NULL) lov_emerg_free(ld->ld_emrg, nr); kfree(ld);