From: Thomas Petazzoni Date: Mon, 12 May 2014 14:11:39 +0000 (+0200) Subject: ARM: mvebu: mvebu-soc-id: add missing clk_put() call X-Git-Tag: submit/tizen_common/20140730.172411~674 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=34ab79184f4c1cc86b469dadf5b0a449d27822de;p=profile%2Fivi%2Fkernel-x86-ivi.git ARM: mvebu: mvebu-soc-id: add missing clk_put() call commit 42a18d1cf484d02e23afadfa5dc09356e6bef9fa upstream. The mvebu-soc-id code in mach-mvebu/ needs to enable a clock to read the SoC device ID and revision number. To do so, it does a clk_get(), then a clk_prepare_enable(), reads the value, and disables the clock with clk_disable_unprepare(). However, it forgets to clk_put() the clock. This commit fixes this issue. Signed-off-by: Thomas Petazzoni Link: https://lkml.kernel.org/r/1399903900-29977-2-git-send-email-thomas.petazzoni@free-electrons.com Fixes: af8d1c63afcb ("ARM: mvebu: Add support to get the ID and the revision of a SoC") Acked-by: Gregory CLEMENT Tested-by: Gregory CLEMENT Tested-by: Andrew Lunn Tested-by: Willy Tarreau Signed-off-by: Jason Cooper Signed-off-by: Greg Kroah-Hartman --- diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c index f3b325f..a3b6d5f 100644 --- a/arch/arm/mach-mvebu/mvebu-soc-id.c +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c @@ -108,6 +108,7 @@ static int __init mvebu_soc_id_init(void) res_ioremap: clk_disable_unprepare(clk); + clk_put(clk); clk_err: of_node_put(child);