From: Tejun Heo Date: Sat, 22 Dec 2012 01:57:12 +0000 (-0800) Subject: usb: gadget: at91_udc: don't use [delayed_]work_pending() X-Git-Tag: v3.9-rc1~126^2~43^2~46 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=348409a267e441c46345f325db37e9824fcf675e;p=platform%2Fkernel%2Flinux-3.10.git usb: gadget: at91_udc: don't use [delayed_]work_pending() There's no need to test whether a (delayed) work item in pending before queueing, flushing or cancelling it. Most uses are unnecessary and quite a few of them are buggy. Remove unnecessary pending tests from at91_udc. Only compile tested. Signed-off-by: Tejun Heo Cc: Andrew Victor Cc: Jean-Christophe Plagniol-Villard Cc: linux-usb@vger.kernel.org Acked-by: Nicolas Ferre Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index f4a21f6..e81d8a2 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -1621,8 +1621,7 @@ static void at91_vbus_timer(unsigned long data) * bus such as i2c or spi which may sleep, so schedule some work * to read the vbus gpio */ - if (!work_pending(&udc->vbus_timer_work)) - schedule_work(&udc->vbus_timer_work); + schedule_work(&udc->vbus_timer_work); } static int at91_start(struct usb_gadget *gadget,