From: Xiubo Li Date: Thu, 9 Jan 2014 09:49:40 +0000 (+0800) Subject: ASoC: simple-card: fix the cinfo error check X-Git-Tag: accepted/tizen/common/20141203.182822~641^2~11^2^2^7~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=34787d0a258ebb3686676fb37a9e8717cbdd835a;p=platform%2Fkernel%2Flinux-arm64.git ASoC: simple-card: fix the cinfo error check If the dt is used and the cinfo is NULL, the -ENOMEM should be return. Signed-off-by: Xiubo Li Signed-off-by: Mark Brown --- diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 6c61b17..11030a6 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -211,15 +211,17 @@ static int asoc_simple_card_probe(struct platform_device *pdev) dev_err(dev, "parse error %d\n", ret); return ret; } + } else { + return -ENOMEM; } } else { cinfo = pdev->dev.platform_data; - cinfo->snd_card.dev = &pdev->dev; - } + if (!cinfo) { + dev_err(dev, "no info for asoc-simple-card\n"); + return -EINVAL; + } - if (!cinfo) { - dev_err(dev, "no info for asoc-simple-card\n"); - return -EINVAL; + cinfo->snd_card.dev = &pdev->dev; } if (!cinfo->name ||