From: Lucas Stach Date: Fri, 11 Nov 2022 16:29:18 +0000 (+0100) Subject: etnaviv: don't always emit PE_DEPTH_CONFIG on shader changes X-Git-Tag: upstream/23.3.3~16948 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3408cce076467266da1c53a1a8f4045fbc2d7118;p=platform%2Fupstream%2Fmesa.git etnaviv: don't always emit PE_DEPTH_CONFIG on shader changes Since b29fe26d4387 ("etnaviv: rework ZSA into a derived state") the PE depth config is adjusted by etna_update_zsa() when the shader is changed. When the PE depth config is actually changing as a result of this adjustment the ZSA state is dirtied, so there is no need to emit the state unconditionally when the shader is changed. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Part-of: --- diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.c b/src/gallium/drivers/etnaviv/etnaviv_emit.c index ccb2b8c..ddf1397 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_emit.c +++ b/src/gallium/drivers/etnaviv/etnaviv_emit.c @@ -429,7 +429,7 @@ etna_emit_state(struct etna_context *ctx) /*01010*/ EMIT_STATE(PS_CONTROL, ctx->framebuffer.PS_CONTROL); /*01030*/ EMIT_STATE(PS_CONTROL_EXT, ctx->framebuffer.PS_CONTROL_EXT); } - if (unlikely(dirty & (ETNA_DIRTY_ZSA | ETNA_DIRTY_FRAMEBUFFER | ETNA_DIRTY_SHADER))) { + if (unlikely(dirty & (ETNA_DIRTY_ZSA | ETNA_DIRTY_FRAMEBUFFER))) { /*01400*/ EMIT_STATE(PE_DEPTH_CONFIG, (etna_zsa_state(ctx->zsa)->PE_DEPTH_CONFIG | ctx->framebuffer.PE_DEPTH_CONFIG)); }