From: Linus Walleij Date: Tue, 22 Dec 2015 14:51:39 +0000 (+0100) Subject: ASoC: ac97: Be sure to clamp return value X-Git-Tag: v4.5-rc1~20^2~37^2~1^2~10^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=34015f5e56c71bbdcf7189430ffb63ea67656a35;p=platform%2Fkernel%2Flinux-exynos.git ASoC: ac97: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index ae563e3..733f512 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -92,7 +92,7 @@ static int snd_soc_ac97_gpio_get(struct gpio_chip *chip, unsigned offset) dev_dbg(codec->dev, "get gpio %d : %d\n", offset, ret < 0 ? ret : ret & (1 << offset)); - return ret < 0 ? ret : ret & (1 << offset); + return ret < 0 ? ret : !!(ret & (1 << offset)); } static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned offset,