From: Chuhong Yuan Date: Mon, 18 Nov 2019 07:38:02 +0000 (+0800) Subject: dmaengine: ti: edma: fix missed failure handling X-Git-Tag: v5.10.7~3742^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=340049d453682a9fe8d91fe794dd091730f4bb25;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: ti: edma: fix missed failure handling When devm_kcalloc fails, it forgets to call edma_free_slot. Replace direct return with failure handler to fix it. Fixes: 1be5336bc7ba ("dmaengine: edma: New device tree binding") Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191118073802.28424-1-hslester96@gmail.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c index 0ecfc2e..756a3c9 100644 --- a/drivers/dma/ti/edma.c +++ b/drivers/dma/ti/edma.c @@ -2424,8 +2424,10 @@ static int edma_probe(struct platform_device *pdev) ecc->tc_list = devm_kcalloc(dev, ecc->num_tc, sizeof(*ecc->tc_list), GFP_KERNEL); - if (!ecc->tc_list) - return -ENOMEM; + if (!ecc->tc_list) { + ret = -ENOMEM; + goto err_reg1; + } for (i = 0;; i++) { ret = of_parse_phandle_with_fixed_args(node, "ti,tptcs",