From: Uwe Kleine-König Date: Wed, 6 Jun 2012 09:49:23 +0000 (+0200) Subject: gpio/mxc: make irqs work for fsl,imx21-gpio devices X-Git-Tag: upstream/snapshot3+hdmi~7107^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=33a4e985bab25d6753b52d1322b4e2fff706dd4f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git gpio/mxc: make irqs work for fsl,imx21-gpio devices The chained handler was set for the platform device with id == 0. When the gpio devices are instantiated by a device tree, all have id == -1 and so the handler was unset resulting in unusable gpio irqs on i.MX21 and i.MX27 (when using oftree). Acked-by: Shawn Guo Cc: Grant Likely Signed-off-by: Uwe Kleine-König Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index c337143..c89c4c1 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -398,10 +398,12 @@ static int __devinit mxc_gpio_probe(struct platform_device *pdev) writel(~0, port->base + GPIO_ISR); if (mxc_gpio_hwtype == IMX21_GPIO) { - /* setup one handler for all GPIO interrupts */ - if (pdev->id == 0) - irq_set_chained_handler(port->irq, - mx2_gpio_irq_handler); + /* + * Setup one handler for all GPIO interrupts. Actually setting + * the handler is needed only once, but doing it for every port + * is more robust and easier. + */ + irq_set_chained_handler(port->irq, mx2_gpio_irq_handler); } else { /* setup one handler for each entry */ irq_set_chained_handler(port->irq, mx3_gpio_irq_handler);