From: Lennart Poettering Date: Fri, 22 Jan 2016 11:04:36 +0000 (+0100) Subject: resolved: fix rcode formatting string length X-Git-Tag: v231~731^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3347dd5ea1dba5e27a677954b505bb6a2ee6cd75;p=platform%2Fupstream%2Fsystemd.git resolved: fix rcode formatting string length Since we honour the edns rcode extension we need more than 4 bits to format it. To avoid further confusion, derive the right length from the type. --- diff --git a/src/resolve/resolved-bus.c b/src/resolve/resolved-bus.c index bc2d6dd..2cb6228 100644 --- a/src/resolve/resolved-bus.c +++ b/src/resolve/resolved-bus.c @@ -69,7 +69,7 @@ static int reply_query_state(DnsQuery *q) { sd_bus_error_setf(&error, _BUS_ERROR_DNS "NXDOMAIN", "'%s' not found", dns_query_string(q)); else { const char *rc, *n; - char p[3]; /* the rcode is 4 bits long */ + char p[DECIMAL_STR_MAX(q->answer_rcode)]; rc = dns_rcode_to_string(q->answer_rcode); if (!rc) {