From: Bernhard Kohl Date: Tue, 31 Aug 2010 12:08:27 +0000 (+0200) Subject: scsi-disk: fix the check of the DBD bit in the MODE SENSE command X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~7218^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=333d50fe3d9a1ff0a6a1a44ef42a0d3a2a7f2abe;p=sdk%2Femulator%2Fqemu.git scsi-disk: fix the check of the DBD bit in the MODE SENSE command The DBD bit does not work as expected. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "A disable block descriptors (DBD) bit of zero indicates that the target may return zero or more block descriptors in the returned MODE SENSE data (see 8.3.3), at the target's discretion. A DBD bit of one specifies that the target shall not return any block descriptors in the returned MODE SENSE data." Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 44f99b0..0c90c77 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -655,7 +655,7 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf) } bdrv_get_geometry(s->bs, &nb_sectors); - if ((~dbd) & nb_sectors) { + if (!dbd && nb_sectors) { if (req->cmd.buf[0] == MODE_SENSE) { outbuf[3] = 8; /* Block descriptor length */ } else { /* MODE_SENSE_10 */