From: Julian Lettner <jlettner@apple.com>
Date: Mon, 21 Oct 2019 21:57:18 +0000 (+0000)
Subject: [lit] Simplify test scheduling via multiprocessing.Pool
X-Git-Tag: llvmorg-11-init~6001
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3330cad630772c76fcf5b49bb25d973f43de64aa;p=platform%2Fupstream%2Fllvm.git

[lit] Simplify test scheduling via multiprocessing.Pool

llvm-svn: 375458
---

diff --git a/llvm/utils/lit/lit/run.py b/llvm/utils/lit/lit/run.py
index a246eaa..d39b4b1 100644
--- a/llvm/utils/lit/lit/run.py
+++ b/llvm/utils/lit/lit/run.py
@@ -127,27 +127,20 @@ class ParallelRun(Run):
                 return True
             lit.util.win32api.SetConsoleCtrlHandler(console_ctrl_handler, True)
 
-        try:
-            async_results = [
-                pool.apply_async(lit.worker.execute, args=[test],
-                    callback=lambda r, t=test: self._process_result(t, r))
-                for test in self.tests]
-            pool.close()
-
-            # Wait for all results to come in. The callback that runs in the
-            # parent process will update the display.
-            for a in async_results:
-                timeout = deadline - time.time()
-                a.wait(timeout)
-                if not a.successful():
-                    # TODO(yln): this also raises on a --max-time time
-                    a.get() # Exceptions raised here come from the worker.
-                if self.hit_max_failures:
-                    break
-        except:
-            # Stop the workers and wait for any straggling results to come in
-            # if we exited without waiting on every async result.
-            pool.terminate()
-            raise
-        finally:
-            pool.join()
+        async_results = [
+            pool.apply_async(lit.worker.execute, args=[test],
+                callback=lambda r, t=test: self._process_result(t, r))
+            for test in self.tests]
+        pool.close()
+
+        for ar in async_results:
+            timeout = deadline - time.time()
+            try:
+                ar.get(timeout)
+            except multiprocessing.TimeoutError:
+                # TODO(yln): print timeout error
+                pool.terminate()
+                break
+            if self.hit_max_failures:
+                pool.terminate()
+                break