From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 14 May 2014 01:03:48 +0000 (+0930)
Subject: drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.
X-Git-Tag: v3.16-rc1~40^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=332e2b4f515953bd53ada64c2873c6e40c66986b;p=platform%2Fkernel%2Flinux-exynos.git

drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.

In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Lindar Liu <lindar_liu@usish.com>
Cc: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---

diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 28b4e81..62c884e 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -729,7 +729,7 @@ static ssize_t pm8001_show_update_fw(struct device *cdev,
 			flash_error_table[i].reason);
 }
 
-static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUGO,
+static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP,
 	pm8001_show_update_fw, pm8001_store_update_fw);
 struct device_attribute *pm8001_host_attrs[] = {
 	&dev_attr_interface_rev,