From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Fri, 17 Sep 2010 09:44:29 +0000 (+0200)
Subject: Revert "sdp: Remove useless check in macro"
X-Git-Tag: 1.19.3~511^2~8043
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3328f89c494028aeedf84ae8a07b1f32a292f9f1;p=platform%2Fupstream%2Fgstreamer.git

Revert "sdp: Remove useless check in macro"

This reverts commit e6a041b69fd21c42651d98cf8a3064e43cecc51c.

It's not a useless check, the signedness of "char" and "gchar" is
defined by the ABI.
---

diff --git a/gst-libs/gst/sdp/gstsdpmessage.c b/gst-libs/gst/sdp/gstsdpmessage.c
index ba89275..7e3bbb8 100644
--- a/gst-libs/gst/sdp/gstsdpmessage.c
+++ b/gst-libs/gst/sdp/gstsdpmessage.c
@@ -598,7 +598,7 @@ static const guchar acceptable[96] = {
 
 static const gchar hex[16] = "0123456789ABCDEF";
 
-#define ACCEPTABLE_CHAR(a) ((a)>=32 && acceptable[(a)-32])
+#define ACCEPTABLE_CHAR(a) ((a)>=32 && (a)<128 && acceptable[(a)-32])
 
 /**
  * gst_sdp_message_as_uri: