From: Connor Hansen Date: Sat, 11 Jun 2011 22:06:48 +0000 (-0700) Subject: ide-cd: signedness warning fix again X-Git-Tag: v3.0-rc3~11^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3307d0d83b7bf636dc6dd2aa4a584d0f52cc185b;p=profile%2Fivi%2Fkernel-x86-ivi.git ide-cd: signedness warning fix again One of the legit warnings 'make W=3 drivers/ide/ide-cd.c' generates is: drivers/ide/ide-cd.c: In function ide_cd_do_request drivers/ide/ide-cd.c:828:2: warning: conversion to int from \ unsigned int may change the sign of the result drivers/ide/ide-cd.c:833:2: warning: conversion to int from \ unsigned int may change the sign of the result nsectors is declared int, should be unsigned int. blk_rq_sectors() returns unsigned int, and ide_complete_rq expects unsigned int as well. Fixes both warnings. Signed-off-by: Connor Hansen Signed-off-by: David S. Miller --- diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 144d272..04b0956 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -778,7 +778,8 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq, sector_t block) { struct ide_cmd cmd; - int uptodate = 0, nsectors; + int uptodate = 0; + unsigned int nsectors; ide_debug_log(IDE_DBG_RQ, "cmd: 0x%x, block: %llu", rq->cmd[0], (unsigned long long)block);