From: Johannes Berg Date: Mon, 25 Aug 2014 10:08:09 +0000 (+0200) Subject: Revert "mac80211: disable uAPSD if all ACs are under ACM" X-Git-Tag: upstream/snapshot3+hdmi~1490 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=32fcd59e6ba2fec1707bca80da3c4e5a5f5558a5;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git Revert "mac80211: disable uAPSD if all ACs are under ACM" commit bb512ad0732232f1d2693bb68f31a76bed8f22ae upstream. This reverts commit 24aa11ab8ae03292d38ec0dbd9bc2ac49fe8a6dd. That commit was wrong since it uses data that hasn't even been set up yet, but might be a hold-over from a previous connection. Additionally, it seems like a driver-specific workaround that shouldn't have been in mac80211 to start with. Fixes: 24aa11ab8ae0 ("mac80211: disable uAPSD if all ACs are under ACM") Reviewed-by: Luciano Coelho Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index e6a84cb..189eef0 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -4240,8 +4240,7 @@ int ieee80211_mgd_assoc(struct ieee80211_sub_if_data *sdata, rcu_read_unlock(); if (bss->wmm_used && bss->uapsd_supported && - (sdata->local->hw.flags & IEEE80211_HW_SUPPORTS_UAPSD) && - sdata->wmm_acm != 0xff) { + (sdata->local->hw.flags & IEEE80211_HW_SUPPORTS_UAPSD)) { assoc_data->uapsd = true; ifmgd->flags |= IEEE80211_STA_UAPSD_ENABLED; } else {