From: Russell King (Oracle) Date: Wed, 7 Jun 2023 11:59:04 +0000 (+0100) Subject: net: fman_memac: use pcs-lynx's check for fwnode availability X-Git-Tag: v6.6.17~4555^2~146^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=32fc30353f7c4d5370acf6ef8fb3be9363dce3c2;p=platform%2Fkernel%2Flinux-rpi.git net: fman_memac: use pcs-lynx's check for fwnode availability Use pcs-lynx's check rather than our own when determining if the device is available. This fixes a bug where the reference gained by of_parse_phandle() is not dropped if the device is not available. Signed-off-by: Russell King (Oracle) Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c index 4fbdae996d05..3b75cc543be9 100644 --- a/drivers/net/ethernet/freescale/fman/fman_memac.c +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c @@ -1042,7 +1042,7 @@ static struct phylink_pcs *memac_pcs_create(struct device_node *mac_node, struct phylink_pcs *pcs; node = of_parse_phandle(mac_node, "pcsphy-handle", index); - if (!node || !of_device_is_available(node)) + if (!node) return ERR_PTR(-ENODEV); pcs = lynx_pcs_create_fwnode(of_fwnode_handle(node));