From: Sergei Shtylyov Date: Tue, 21 May 2013 19:24:22 +0000 (+0400) Subject: [SCSI] ipr: qc_fill_rtf() method should not store alternate status register X-Git-Tag: upstream/snapshot3+hdmi~4777^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=32d3d793fb2d40d2a255af64ffa17cfb2132c323;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git [SCSI] ipr: qc_fill_rtf() method should not store alternate status register The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e. it is not intended for storing the alternate status register (which is mapped at the same address in the legacy IDE controllers) in the qc_fill_rtf() method. No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status register's value in the 'ctl' field of 'qc->result_tf', hence this driver should not do this as well... Signed-off-by: Sergei Shtylyov Acked-by: Brian King Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index a87767f..0d43176 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_queued_cmd *qc) tf->hob_lbal = g->hob_lbal; tf->hob_lbam = g->hob_lbam; tf->hob_lbah = g->hob_lbah; - tf->ctl = g->alt_status; return true; }