From: Hans de Goede <hdegoede@redhat.com>
Date: Tue, 19 Jul 2011 12:05:49 +0000 (-0300)
Subject: [media] pwc: Properly mark device_hint as unused in all probe error paths
X-Git-Tag: v3.12-rc1~3230^2~208
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=32c67ecc4a690220cbd9fda442c70bc4ba9b2dac;p=kernel%2Fkernel-generic.git

[media] pwc: Properly mark device_hint as unused in all probe error paths

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
index df63926..c1806e3a 100644
--- a/drivers/media/video/pwc/pwc-if.c
+++ b/drivers/media/video/pwc/pwc-if.c
@@ -1266,14 +1266,14 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
 	return 0;
 
 err_video_unreg:
-	if (hint < MAX_DEV_HINTS)
-		device_hint[hint].pdev = NULL;
 	video_unregister_device(&pdev->vdev);
 err_unregister_v4l2_dev:
 	v4l2_device_unregister(&pdev->v4l2_dev);
 err_free_controls:
 	v4l2_ctrl_handler_free(&pdev->ctrl_handler);
 err_free_mem:
+	if (hint < MAX_DEV_HINTS)
+		device_hint[hint].pdev = NULL;
 	kfree(pdev);
 	return rc;
 }