From: Alexander Shiyan Date: Sat, 7 Dec 2013 09:00:43 +0000 (+0400) Subject: mfd: mc13xxx: Remove redundant checks X-Git-Tag: v5.15~18622^2~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=328fe79cac65331cbf22c8eefcb2a1f9164974ac;p=platform%2Fkernel%2Flinux-starfive.git mfd: mc13xxx: Remove redundant checks Checking for maximal register is already provided by regmap API, so remove redundant checks. Signed-off-by: Alexander Shiyan Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index dbbf8ee3..b0c7cb0 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -158,9 +158,6 @@ int mc13xxx_reg_read(struct mc13xxx *mc13xxx, unsigned int offset, u32 *val) { int ret; - if (offset > MC13XXX_NUMREGS) - return -EINVAL; - ret = regmap_read(mc13xxx->regmap, offset, val); dev_vdbg(mc13xxx->dev, "[0x%02x] -> 0x%06x\n", offset, *val); @@ -172,7 +169,7 @@ int mc13xxx_reg_write(struct mc13xxx *mc13xxx, unsigned int offset, u32 val) { dev_vdbg(mc13xxx->dev, "[0x%02x] <- 0x%06x\n", offset, val); - if (offset > MC13XXX_NUMREGS || val > 0xffffff) + if (val >= BIT(24)) return -EINVAL; return regmap_write(mc13xxx->regmap, offset, val);