From: Bjørn Mork Date: Mon, 21 Jan 2013 05:50:39 +0000 (+0000) Subject: net: cdc_mbim: send ZLP after max sized NTBs X-Git-Tag: upstream/snapshot3+hdmi~5814^2~29^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=328d7b8a4ab045484e1cc09579abf13c8c6223e3;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git net: cdc_mbim: send ZLP after max sized NTBs We normally avoid sending ZLPs by padding NTBs with a zero byte if the NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet instead of a ZLP. But in the case where the NTB length is exactly dwNtbOutMaxSize and this is an exact multiplum of wMaxPacketSize, then we must send a ZLP. This fixes an issue seen on a Sierra Wireless MC7710 device where the transmission would fail whenever we ended up padding the NTBs to max size. Signed-off-by: Bjørn Mork Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c index 42f51c7..3a5673a 100644 --- a/drivers/net/usb/cdc_mbim.c +++ b/drivers/net/usb/cdc_mbim.c @@ -366,7 +366,7 @@ err: static const struct driver_info cdc_mbim_info = { .description = "CDC MBIM", - .flags = FLAG_NO_SETINT | FLAG_MULTI_PACKET | FLAG_WWAN, + .flags = FLAG_NO_SETINT | FLAG_MULTI_PACKET | FLAG_WWAN | FLAG_SEND_ZLP, .bind = cdc_mbim_bind, .unbind = cdc_mbim_unbind, .manage_power = cdc_mbim_manage_power,