From: saerome kim Date: Fri, 10 May 2019 05:43:23 +0000 (+0900) Subject: Fixed svace issues X-Git-Tag: submit/tizen/20190510.065918^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=326412d9da8654782c30fa895a8e937e2b7cfef7;p=platform%2Fcore%2Fapi%2Fmulti-device-group.git Fixed svace issues - 372991: fixed memory leak issue. - 372995: change a vulnerable function (strerror) to strerror_r. Change-Id: I2d5e6b815149b30afe0511b831c8d2325abb21b1 Signed-off-by: saerome kim --- diff --git a/src/mdg_dbus.c b/src/mdg_dbus.c old mode 100755 new mode 100644 index f10dd00..5e439f0 --- a/src/mdg_dbus.c +++ b/src/mdg_dbus.c @@ -177,7 +177,9 @@ static void __event_cb(Group *object, ret = connect(channel->client_sockfd, (struct sockaddr *)&serveraddr, sizeof(serveraddr)); if (ret == -1) { - _DBG("Connect error : %s", strerror(errno)); + char buf[128]; + strerror_r(errno, buf, 128); + _DBG("Connect error : %s", buf); } else { _DBG("Success Connect to %s", ret_ptr); } diff --git a/test/mdg-manager.c b/test/mdg-manager.c old mode 100755 new mode 100644 index cec9ac7..35fca8f --- a/test/mdg-manager.c +++ b/test/mdg-manager.c @@ -1234,10 +1234,16 @@ void _mdg_channel_client_opened_cb(int result, mdg_channel_h channel, void *user unsigned char *buf; buf = (unsigned char *)malloc(1024); + if (NULL == buf) { + msgp("memory allocation error"); + return; + } int len; mdg_channel_read(channel, &buf, &len); msgp("Get Data : %s, %d", buf, len); + free(buf); + buf = NULL; } static int __request_open_channel(int devidx, int chaidx)