From: Sean Young <sean@mess.org>
Date: Wed, 1 Feb 2017 22:08:56 +0000 (-0200)
Subject: [media] lirc: cannot read from tx-only device
X-Git-Tag: v4.11-rc2~21^2~41
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=32002f725fc708dccc6263b19b56fa3d91626be1;p=platform%2Fkernel%2Flinux-exynos.git

[media] lirc: cannot read from tx-only device

Bail out early, otherwise we follow a null pointer.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 0030ce0..a54ca53 100644
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -647,6 +647,9 @@ ssize_t lirc_dev_fop_read(struct file *file,
 		return -ENODEV;
 	}
 
+	if (!LIRC_CAN_REC(ir->d.features))
+		return -EINVAL;
+
 	dev_dbg(ir->d.dev, LOGHEAD "read called\n", ir->d.name, ir->d.minor);
 
 	buf = kzalloc(ir->chunk_size, GFP_KERNEL);