From: Father Chrysostomos Date: Sun, 24 Oct 2010 00:04:42 +0000 (-0700) Subject: sv_setsv_flags was also using a potentially freed HV X-Git-Tag: accepted/trunk/20130322.191538~7208 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=31f1461f4bbbc0db195fcb42708a5e4340d7eee0;p=platform%2Fupstream%2Fperl.git sv_setsv_flags was also using a potentially freed HV --- diff --git a/sv.c b/sv.c index a091bf0..a42452a 100644 --- a/sv.c +++ b/sv.c @@ -4033,7 +4033,11 @@ Perl_sv_setsv_flags(pTHX_ SV *dstr, register SV* sstr, const I32 flags) if (len > 1 && name[len-2] == ':' && name[len-1] == ':') { /* Set aside the old stash, so we can reset isa caches on its subclasses. */ - old_stash = GvHV(dstr); + if((old_stash = GvHV(dstr))); + /* Make sure we do not lose it early. */ + SvREFCNT_inc_simple_void_NN( + sv_2mortal((SV *)old_stash) + ); reset_isa = TRUE; }