From: Jessica Paquette <jpaquette@apple.com>
Date: Tue, 4 Sep 2018 21:03:43 +0000 (+0000)
Subject: [NFC] Improve clarity in emitInstrCountChangedRemark
X-Git-Tag: llvmorg-8.0.0-rc1~9480
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=31d2e5e546c9b3ad6cbcccbe40d2b6bf582a854b;p=platform%2Fupstream%2Fllvm.git

[NFC] Improve clarity in emitInstrCountChangedRemark

Add a "CouldOnlyImpactOneFunction" bool that's true when we pass in a function.

Just cleaning up a little bit, since I'm going to add in the per-function
remarks soon from D51467.

llvm-svn: 341407
---

diff --git a/llvm/lib/IR/LegacyPassManager.cpp b/llvm/lib/IR/LegacyPassManager.cpp
index b06d596..5435e07 100644
--- a/llvm/lib/IR/LegacyPassManager.cpp
+++ b/llvm/lib/IR/LegacyPassManager.cpp
@@ -152,8 +152,11 @@ void PMDataManager::emitInstrCountChangedRemark(Pass *P, Module &M,
   if (P->getAsPMDataManager())
     return;
 
+  // Set to true if this isn't a module pass or CGSCC pass.
+  bool CouldOnlyImpactOneFunction = (F != nullptr);
+
   // Do we have a function we can use to emit a remark?
-  if (F == nullptr) {
+  if (!CouldOnlyImpactOneFunction) {
     // We need a function containing at least one basic block in order to output
     // remarks. Since it's possible that the first function in the module
     // doesn't actually contain a basic block, we have to go and find one that's