From: 강용구/Security&Privacy팀(SR)/삼성전자 <ygace.kang@samsung.com>
Date: Thu, 11 Jan 2024 02:53:14 +0000 (+0900)
Subject: Fix name of member variables (#36)
X-Git-Tag: accepted/tizen/unified/20240220.115627~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=31cd2be4e46e255dd4191b95046f970abd20045c;p=platform%2Fcore%2Fsecurity%2Fwebauthn.git

Fix name of member variables (#36)
---

diff --git a/srcs/server/service.cpp b/srcs/server/service.cpp
index 5c2e15d..3210025 100644
--- a/srcs/server/service.cpp
+++ b/srcs/server/service.cpp
@@ -353,7 +353,7 @@ void Service::processCancel(SocketManager::ConnectionID connectionID,
 int Service::checkBusyAndCred(SocketManager::ConnectionID connectionID)
 {
     std::lock_guard<std::mutex> ulock(m_isBusyMutex);
-    if (isBusy)
+    if (m_isBusy)
     {
         Cred nowCreds;
         int ret = getCredentials(connectionID, &nowCreds);
@@ -362,7 +362,7 @@ int Service::checkBusyAndCred(SocketManager::ConnectionID connectionID)
             LogError("Error on get credentials");
             return -1;
         }
-        if (credentials.smack == nowCreds.smack && credentials.cred.pid == nowCreds.cred.pid)
+        if (m_credentials.smack == nowCreds.smack && m_credentials.cred.pid == nowCreds.cred.pid)
         {
             LogDebug("Server is Busy and Credentials are matched");
             return 1;
@@ -383,10 +383,10 @@ int Service::checkBusyAndCred(SocketManager::ConnectionID connectionID)
 int Service::checkBusyAndSet(SocketManager::ConnectionID connectionID)
 {
     std::lock_guard<std::mutex> ulock(m_isBusyMutex);
-    if (isBusy)
+    if (m_isBusy)
         return 1;
     else{
-        isBusy = true;
+        m_isBusy = true;
         int ret = setCredentials(connectionID);
         if (-1 == ret)
         {
@@ -401,13 +401,13 @@ int Service::checkBusyAndSet(SocketManager::ConnectionID connectionID)
 void Service::unsetBusy()
 {
     std::lock_guard<std::mutex> ulock(m_isBusyMutex);
-    isBusy = false;
+    m_isBusy = false;
     LogDebug("Set not Busy");
 }
 
 int Service::setCredentials(SocketManager::ConnectionID connectionID)
 {
-    return getCredentials(connectionID, &credentials);
+    return getCredentials(connectionID, &m_credentials);
 }
 
 int Service::getCredentials(SocketManager::ConnectionID connectionID, Cred *creds)
diff --git a/srcs/server/service.h b/srcs/server/service.h
index 4b5612c..ec97659 100644
--- a/srcs/server/service.h
+++ b/srcs/server/service.h
@@ -151,9 +151,9 @@ private:
      */
     int getCredentials(SocketManager::ConnectionID connectionID, Cred *creds);
 
-    bool isBusy = false;
+    bool m_isBusy = false;
     std::mutex m_isBusyMutex;
-    Cred credentials;
+    Cred m_credentials;
 };
 
 } // namespace WebAuthn