From: Eric Andersen <andersen@codepoet.org>
Date: Fri, 8 Oct 2004 08:10:57 +0000 (-0000)
Subject: Hiroshi Ito writes:
X-Git-Tag: 1_00~17
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=31c27a9c6559b46c5e20fd64eaa8019daaba5e5c;p=platform%2Fupstream%2Fbusybox.git

Hiroshi Ito writes:

    Hello

    I'm using busy box on mipsel machine.

    "grep -f file" will cause segmentation fault.

Vladimir N. Oleynik writes:

Hiroshi,

Thank for bug report, but your patch is full broken.
Worked patch attached.
(really changes is zero initialize, and indent correcting).


--w
vodz
---

diff --git a/findutils/grep.c b/findutils/grep.c
index ddc5cea..29f4ecd 100644
--- a/findutils/grep.c
+++ b/findutils/grep.c
@@ -249,9 +249,9 @@ static void load_regexes_from_file(llist_t *fopt)
 		fopt = cur->link;
 		free(cur);
 		f = bb_xfopen(ffile, "r");
-	while ((line = bb_get_chomped_line_from_file(f)) != NULL) {
-		pattern_head = llist_add_to(pattern_head, line);
-	}
+		while ((line = bb_get_chomped_line_from_file(f)) != NULL) {
+			pattern_head = llist_add_to(pattern_head, line);
+		}
 	}
 }
 
@@ -261,7 +261,7 @@ extern int grep_main(int argc, char **argv)
 	FILE *file;
 	int matched;
 	unsigned long opt;
-	llist_t *fopt;
+	llist_t *fopt = NULL;
 
 	/* do normal option parsing */
 #ifdef CONFIG_FEATURE_GREP_CONTEXT