From: Ben Adams <thundercat@illyriad.co.uk>
Date: Mon, 24 Dec 2018 02:09:46 +0000 (+0000)
Subject: Fix warning causing error in warning as error (Windows) (dotnet/coreclr#21656)
X-Git-Tag: submit/tizen/20210909.063632~11030^2~2999
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=31adf846b4d5a83ac73501ffdd0809b41a98093b;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Fix warning causing error in warning as error (Windows) (dotnet/coreclr#21656)



Commit migrated from https://github.com/dotnet/coreclr/commit/5b0f1a1d183f83a077771feca7cea90b8159863a
---

diff --git a/src/coreclr/src/vm/jitinterface.cpp b/src/coreclr/src/vm/jitinterface.cpp
index 0730f37..c7d55b5 100644
--- a/src/coreclr/src/vm/jitinterface.cpp
+++ b/src/coreclr/src/vm/jitinterface.cpp
@@ -6033,8 +6033,8 @@ CorInfoHelpFunc CEEInfo::getNewHelperStatic(MethodTable * pMT, bool * pHasSideEf
 
     // Slow helper is the default
     CorInfoHelpFunc helper = CORINFO_HELP_NEWFAST;
-    bool hasFinalizer = pMT->HasFinalizer();
-    bool isComObjectType = pMT->IsComObjectType();
+    BOOL hasFinalizer = pMT->HasFinalizer();
+    BOOL isComObjectType = pMT->IsComObjectType();
 
     if (pHasSideEffects != nullptr)
     {
@@ -6051,7 +6051,7 @@ CorInfoHelpFunc CEEInfo::getNewHelperStatic(MethodTable * pMT, bool * pHasSideEf
         else
 #endif
         {
-            *pHasSideEffects = hasFinalizer;
+            *pHasSideEffects = !!hasFinalizer;
         }
     }