From: Uwe Kleine-König Date: Wed, 7 Jul 2021 16:28:22 +0000 (+0200) Subject: pwm: atmel-tcb: Don't check the return code of pwmchip_remove() X-Git-Tag: accepted/tizen/unified/20230118.172025~6393^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=319333b0c48e98fe84e81c1f68384353dc37dd61;p=platform%2Fkernel%2Flinux-rpi.git pwm: atmel-tcb: Don't check the return code of pwmchip_remove() pwmchip_remove() returns always 0. Don't use the value to make it possible to eventually change the function to return void. Also the driver core ignores the return value of atmel_tcb_pwm_remove() and considers the device removed anyhow. So returning early results in a resource leak. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c index bf398f2..36f7ea3 100644 --- a/drivers/pwm/pwm-atmel-tcb.c +++ b/drivers/pwm/pwm-atmel-tcb.c @@ -503,11 +503,8 @@ err_slow_clk: static int atmel_tcb_pwm_remove(struct platform_device *pdev) { struct atmel_tcb_pwm_chip *tcbpwm = platform_get_drvdata(pdev); - int err; - err = pwmchip_remove(&tcbpwm->chip); - if (err < 0) - return err; + pwmchip_remove(&tcbpwm->chip); clk_disable_unprepare(tcbpwm->slow_clk); clk_put(tcbpwm->slow_clk);