From: dcarney <dcarney@chromium.org>
Date: Wed, 14 Jan 2015 11:52:24 +0000 (-0800)
Subject: Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of... 
X-Git-Tag: upstream/4.7.83~4990
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=316f860a6bd5fcb55ce0cd4a950e829d2b16acea;p=platform%2Fupstream%2Fv8.git

Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/833563004/)

Reason for revert:
This is now really blocking the roll.  I believe it's just missing

    configs -= [ "//build/config/compiler:chromium_code" ]
    configs += [ "//build/config/compiler:no_chromium_code" ]

in the d8 config but I have no way to check.

Original issue's description:
> Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/838983002/)
>
> Reason for revert:
> Relanding because this is not actually blocking the roll.
>
> Original issue's description:
> > Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/834113005/)
> >
> > Reason for revert:
> > V8 roll fails due to this change. (see https://codereview.chromium.org/843673003/)
> >
> > Original issue's description:
> > > Add d8 target to the GN build.
> > >
> > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions.
> > >
> > > Committed: https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440
> > > Cr-Commit-Position: refs/heads/master@{#25984}
> >
> > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://crrev.com/ef50fdfdb05e1a3a3822962f5235b804218a5f4e
> > Cr-Commit-Position: refs/heads/master@{#25985}
>
> TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/ebf3c34fb91b4b61f5c32383a115214c516ab5b0
> Cr-Commit-Position: refs/heads/master@{#25996}

TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/810493004

Cr-Commit-Position: refs/heads/master@{#26050}
---

diff --git a/BUILD.gn b/BUILD.gn
index 5265129..a524ba1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -191,23 +191,6 @@ action("js2c") {
   }
 }
 
-action("d8_js2c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
-
-  script = "tools/js2c.py"
-
-  inputs = [
-    "src/d8.js",
-    "src/macros.py",
-  ]
-  outputs = [
-    "$target_gen_dir/d8-js.cc",
-  ]
-
-  args = rebase_path(outputs, root_build_dir) + [ "D8" ] +
-         rebase_path(inputs, root_build_dir)
-}
-
 action("js2c_experimental") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
@@ -1421,43 +1404,6 @@ if (current_toolchain == host_toolchain) {
       "//build/config/sanitizers:deps",
     ]
   }
-
-  executable("d8") {
-    sources = [
-      "src/d8.cc",
-    ]
-    deps = [
-      ":d8_js2c",
-      ":v8",
-      ":v8_libplatform",
-    ]
-
-    configs += [
-      ":internal_config",
-      ":features",
-      ":toolchain",
-    ]
-
-    # TODO(GYP): Build option for readline support.
-
-    if (is_posix) {
-      sources += [ "src/d8-posix.cc" ]
-    } else if (is_win) {
-      sources += [ "src/d8-windows.cc" ]
-    }
-
-    if (component_mode != "shared_library") {
-      sources += [
-        "src/d8-debug.cc",
-        "$target_gen_dir/d8-js.cc",
-      ]
-    }
-    if (v8_enable_i18n_support) {
-      deps += [ "//third_party/icu" ]
-    }
-
-    # TODO(GYP) v8_enable_vtunejit support in d8.
-  }
 }
 
 ###############################################################################