From: Sachin Kamat Date: Tue, 20 Nov 2012 09:59:00 +0000 (-0800) Subject: leds: lp5521: Fix return value X-Git-Tag: upstream/snapshot3+hdmi~6054^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=313e8b50c89a76c4f36af527f937c2f8cf4cad41;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git leds: lp5521: Fix return value Return the value obtained from i2c_smbus_read_byte_data() instead of -EIO. Silences the following smatch warning: drivers/leds/leds-lp5521.c:155 lp5521_read() info: why not propagate 'ret' from i2c_smbus_read_byte_data() instead of -5? Signed-off-by: Sachin Kamat Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index 362e29e..8505afe 100644 --- a/drivers/leds/leds-lp5521.c +++ b/drivers/leds/leds-lp5521.c @@ -152,7 +152,7 @@ static int lp5521_read(struct i2c_client *client, u8 reg, u8 *buf) ret = i2c_smbus_read_byte_data(client, reg); if (ret < 0) - return -EIO; + return ret; *buf = ret; return 0;