From: Dan Carpenter Date: Wed, 4 Jul 2018 09:48:53 +0000 (+0300) Subject: xhci: xhci-mem: off by one in xhci_stream_id_to_ring() X-Git-Tag: v4.19~635^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=313db3d6488bb03b61b99de9dbca061f1fd838e1;p=platform%2Fkernel%2Flinux-rpi3.git xhci: xhci-mem: off by one in xhci_stream_id_to_ring() The > should be >= here so that we don't read one element beyond the end of the ep->stream_info->stream_rings[] array. Fixes: e9df17eb1408 ("USB: xhci: Correct assumptions about number of rings per endpoint.") Signed-off-by: Dan Carpenter Cc: stable Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8a62eee..ef350c3 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -595,7 +595,7 @@ struct xhci_ring *xhci_stream_id_to_ring( if (!ep->stream_info) return NULL; - if (stream_id > ep->stream_info->num_streams) + if (stream_id >= ep->stream_info->num_streams) return NULL; return ep->stream_info->stream_rings[stream_id]; }