From: Ian Elliott <ianelliott@google.com>
Date: Wed, 16 Aug 2017 21:11:57 +0000 (-0600)
Subject: Fix flakiness in mailbox.display_timing
X-Git-Tag: upstream/1.3.5~1205^2^2~3^2~40
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=311129dc01f5cc512372dd3dae7b5afbe27f81ec;p=platform%2Fupstream%2FVK-GL-CTS.git

Fix flakiness in mailbox.display_timing

The "vktWsiDisplayTimingTests.cpp" file was originally written just for
a present mode of VK_PRESENT_MODE_FIFO_KHR.  It has a case at image 80,
where it changes the desiredPresentTime to be 1 second earlier, and then
checks that later.  Such a check doesn't work with
VK_PRESENT_MODE_MAILBOX_KHR, which can throw off the timing of images
(because some images may not be presented).  This has resulted in the
test having random failures.  The "image 80 test" wasn't intended to
occur with MAILBOX, and so it's now being removed.

VK-GL-CTS issue: 622
Components: Vulkan
Affects: dEQP-VK.wsi.*.display_timing.mailbox.display_timing
Bug: 64486630
Test: Build cts and ran scripts/check_build_sanity.py

Change-Id: I9fbd2254b4e6fc1c7bff077c8c0a5229a6d74800
---

diff --git a/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayTimingTests.cpp b/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayTimingTests.cpp
index 8c2c405..e8932a8 100644
--- a/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayTimingTests.cpp
+++ b/external/vulkancts/modules/vulkan/wsi/vktWsiDisplayTimingTests.cpp
@@ -1247,7 +1247,7 @@ void DisplayTimingTestInstance::render (void)
 		else
 		{
 			desiredPresentTime = m_prevDesiredPresentTime + m_targetIPD;
-			if (presentTime.presentID == 80)
+			if ((presentTime.presentID == 80) && (m_swapchainConfig.presentMode != vk::VK_PRESENT_MODE_MAILBOX_KHR))
 			{
 				// Test if desiredPresentTime is 1 second earlier (i.e. before the previous image could have been presented)
 				presentTime.desiredPresentTime -= SECOND;