From: Tales Aparecida Date: Thu, 11 Aug 2022 20:43:27 +0000 (-0300) Subject: drm/amd/display: fix minor codestyle problems X-Git-Tag: v6.6.17~6361^2~19^2~164 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30f2d2e49e826c2dda35153d2e108d06f6d7d9dc;p=platform%2Fkernel%2Flinux-rpi.git drm/amd/display: fix minor codestyle problems Fixes five checkpatch warnings: CHECK: Please don't use multiple blank lines + + ERROR: Macros with complex values should be enclosed in parentheses +#define MAX_I64 \ + (int64_t)((1ULL << 63) - 1) WARNING: Missing a blank line after declarations + struct bw_fixed res; + ASSERT(value < BW_FIXED_MAX_I32 && value > BW_FIXED_MIN_I32); ERROR: that open brace { should be on the previous line + do + { ERROR: that open brace { should be on the previous line + if (remainder >= arg2_value) + { Signed-off-by: Tales Aparecida Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c b/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c index 2d46bc5..3aa8dd0 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c +++ b/drivers/gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c @@ -25,9 +25,8 @@ #include "dm_services.h" #include "bw_fixed.h" - #define MAX_I64 \ - (int64_t)((1ULL << 63) - 1) + ((int64_t)((1ULL << 63) - 1)) #define MIN_I64 \ (-MAX_I64 - 1) @@ -49,6 +48,7 @@ static uint64_t abs_i64(int64_t arg) struct bw_fixed bw_int_to_fixed_nonconst(int64_t value) { struct bw_fixed res; + ASSERT(value < BW_FIXED_MAX_I32 && value > BW_FIXED_MIN_I32); res.value = value << BW_FIXED_BITS_PER_FRACTIONAL_PART; return res; @@ -78,14 +78,12 @@ struct bw_fixed bw_frc_to_fixed(int64_t numerator, int64_t denominator) { uint32_t i = BW_FIXED_BITS_PER_FRACTIONAL_PART; - do - { + do { remainder <<= 1; res_value <<= 1; - if (remainder >= arg2_value) - { + if (remainder >= arg2_value) { res_value |= 1; remainder -= arg2_value; }