From: Julia Lawall <julia.lawall@lip6.fr>
Date: Sat, 22 Oct 2016 20:41:32 +0000 (+0200)
Subject: iio: dac: mcp4725: fix odd_ptr_err.cocci warnings
X-Git-Tag: v4.14-rc1~1919^2~508^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30df2d1879ff65af7b269ee94e9c7fc276b54105;p=platform%2Fkernel%2Flinux-rpi.git

iio: dac: mcp4725: fix odd_ptr_err.cocci warnings

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Tomas Novotny <tomas@novotny.cz>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index fae80eb..db109f0 100644
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -449,7 +449,7 @@ static int mcp4725_probe(struct i2c_client *client,
 	if (pdata->use_vref) {
 		data->vref_reg = devm_regulator_get(&client->dev, "vref");
 		if (IS_ERR(data->vref_reg)) {
-			err = PTR_ERR(data->vdd_reg);
+			err = PTR_ERR(data->vref_reg);
 			goto err_disable_vdd_reg;
 		}