From: Weihang Li Date: Fri, 20 Mar 2020 03:23:34 +0000 (+0800) Subject: RDMA/hns: Fix a wrong judgment of return value X-Git-Tag: v5.15~4184^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30d41e18c3a6eac39b7348ae7e3388f0ec7e680e;p=platform%2Fkernel%2Flinux-starfive.git RDMA/hns: Fix a wrong judgment of return value hns_roce_alloc_mtt_range() never return -1, ret should be checked whether it is zero instead of -1. Fixes: 1ceb0b11a8a2 ("RDMA/hns: Fix non-standard error codes") Link: https://lore.kernel.org/r/1584674622-52773-3-git-send-email-liweihang@huawei.com Signed-off-by: Weihang Li Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index b9898e7..176f346 100644 --- a/drivers/infiniband/hw/hns/hns_roce_mr.c +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c @@ -243,7 +243,7 @@ int hns_roce_mtt_init(struct hns_roce_dev *hr_dev, int npages, int page_shift, /* Allocate MTT entry */ ret = hns_roce_alloc_mtt_range(hr_dev, mtt->order, &mtt->first_seg, mtt->mtt_type); - if (ret == -1) + if (ret) return -ENOMEM; return 0;