From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Thu, 27 Aug 2020 05:24:16 +0000 (+0530)
Subject: cpufreq: Use WARN_ON_ONCE() for invalid relation
X-Git-Tag: v5.10.7~1753^2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30b8e6b22fd0f7a56911e69c681e92532e72e3b6;p=platform%2Fkernel%2Flinux-rpi.git

cpufreq: Use WARN_ON_ONCE() for invalid relation

The relation can't be invalid here, so if it turns out to be invalid,
just WARN_ON_ONCE() and return 0.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 8f141d4..a911e5d 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -956,8 +956,8 @@ static inline int cpufreq_frequency_table_target(struct cpufreq_policy *policy,
 	case CPUFREQ_RELATION_C:
 		return cpufreq_table_find_index_c(policy, target_freq);
 	default:
-		pr_err("%s: Invalid relation: %d\n", __func__, relation);
-		return -EINVAL;
+		WARN_ON_ONCE(1);
+		return 0;
 	}
 }