From: Jiri Slaby <jirislaby@gmail.com>
Date: Sun, 21 Jun 2009 21:57:31 +0000 (+0200)
Subject: Firmware: firmware_class, fix lock imbalance
X-Git-Tag: v3.0~8460^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=308975fa7ab2a8e0b91186158128668c823790ce;p=platform%2Fkernel%2Flinux-amlogic.git

Firmware: firmware_class, fix lock imbalance

Add omitted unlock in firmware_data_read.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index fc46653..f285f44 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -217,8 +217,10 @@ firmware_data_read(struct kobject *kobj, struct bin_attribute *bin_attr,
 		ret_count = -ENODEV;
 		goto out;
 	}
-	if (offset > fw->size)
-		return 0;
+	if (offset > fw->size) {
+		ret_count = 0;
+		goto out;
+	}
 	if (count > fw->size - offset)
 		count = fw->size - offset;