From: Dan Carpenter Date: Wed, 4 Jan 2012 07:24:29 +0000 (+0300) Subject: cgroup: move assignement out of condition in cgroup_attach_proc() X-Git-Tag: upstream/snapshot3+hdmi~8416^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=305f3c8b20ba1ca94829329acdbf22e689304dba;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git cgroup: move assignement out of condition in cgroup_attach_proc() Gcc complains about this: "kernel/cgroup.c:2179:4: warning: suggest parentheses around assignment used as truth value [-Wparentheses]" Signed-off-by: Dan Carpenter Signed-off-by: Tejun Heo --- diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 548d8d4..bab5c17 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -2175,9 +2175,12 @@ static int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader) oldcg = tc->task->cgroups; /* if we don't already have it in the list get a new one */ - if (!css_set_check_fetched(cgrp, tc->task, oldcg, &newcg_list)) - if (retval = css_set_prefetch(cgrp, oldcg, &newcg_list)) + if (!css_set_check_fetched(cgrp, tc->task, oldcg, + &newcg_list)) { + retval = css_set_prefetch(cgrp, oldcg, &newcg_list); + if (retval) goto out_list_teardown; + } } /*