From: Mike Blumenkrantz <zmike@samsung.com>
Date: Wed, 29 May 2019 13:23:44 +0000 (-0400)
Subject: eldbus: don't print warnings for user-canceled calls
X-Git-Tag: accepted/tizen/unified/20190604.014647~70
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30587b06ddcb6fd8850556731ba117978df81e15;p=platform%2Fupstream%2Fefl.git

eldbus: don't print warnings for user-canceled calls

Summary:
these are intentionally canceled and not something to be concerned with

@fix
Depends on D8974

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8976
---

diff --git a/src/lib/eldbus/eldbus_proxy.c b/src/lib/eldbus/eldbus_proxy.c
index fdd4fc7..a28fe9f 100644
--- a/src/lib/eldbus/eldbus_proxy.c
+++ b/src/lib/eldbus/eldbus_proxy.c
@@ -814,8 +814,10 @@ _props_get_all(void *data, const Eldbus_Message *msg, Eldbus_Pending *pending)
 
    if (eldbus_message_error_get(msg, &name, &error_msg))
      {
-        WRN("Error getting all properties of %s %s, error message: %s %s",
-            proxy->obj->name, proxy->obj->path, name, error_msg);
+        /* don't print warnings for user-canceled calls */
+        if (!eina_streq(name, "org.enlightenment.DBus.Canceled"))
+          WRN("Error getting all properties of %s %s, error message: %s %s",
+              proxy->obj->name, proxy->obj->path, name, error_msg);
         return;
      }
 
diff --git a/src/lib/elementary/elm_atspi_bridge.c b/src/lib/elementary/elm_atspi_bridge.c
index 18342c4..1bfa6bf 100644
--- a/src/lib/elementary/elm_atspi_bridge.c
+++ b/src/lib/elementary/elm_atspi_bridge.c
@@ -6542,7 +6542,9 @@ _screen_reader_enabled_get(void *data, const Eldbus_Message *msg, Eldbus_Pending
 
    if (eldbus_message_error_get(msg, &errname, &errmsg))
      {
-        WRN("%s %s", errname, errmsg);
+        /* don't print warnings for user-canceled calls */
+        if (!eina_streq(errname, "org.enlightenment.DBus.Canceled"))
+             WRN("%s %s", errname, errmsg);
         return;
      }
    if (!eldbus_message_arguments_get(msg, "v", &variant))