From: Johan Hovold Date: Mon, 6 Mar 2017 16:36:38 +0000 (+0100) Subject: USB: serial: omninet: fix reference leaks at open X-Git-Tag: v4.14-rc1~1307^2~4^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30572418b445d85fcfe6c8fe84c947d2606767d8;p=platform%2Fkernel%2Flinux-rpi.git USB: serial: omninet: fix reference leaks at open This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Cc: stable # 2.6.28 Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index a180b17..76564b3 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port) static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; - struct usb_serial_port *wport; - - wport = serial->port[1]; - tty_port_tty_set(&wport->port, tty); - return usb_serial_generic_open(tty, port); }