From: Takashi Iwai Date: Wed, 4 Jan 2023 15:09:44 +0000 (+0100) Subject: Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing" X-Git-Tag: v6.1.8~364 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=303a04b6562ec7c96eb91a6648a7e7f7e3e10d41;p=platform%2Fkernel%2Flinux-starfive.git Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing" commit 16f1f838442dc6430d32d51ddda347b8421ec34b upstream. This reverts commit ac5e2fb425e1121ceef2b9d1b3ffccc195d55707. The commit caused a regression on Behringer UMC404HD (and likely others). As the change was meant only as a minor optimization, it's better to revert it to address the regression. Reported-and-tested-by: Michael Ralston Cc: Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com Link: https://lore.kernel.org/r/20230104150944.24918-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/usb/stream.c b/sound/usb/stream.c index f75601c..f10f4e6 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1222,6 +1222,12 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, if (err < 0) return err; } + + /* try to set the interface... */ + usb_set_interface(chip->dev, iface_no, 0); + snd_usb_init_pitch(chip, fp); + snd_usb_init_sample_rate(chip, fp, fp->rate_max); + usb_set_interface(chip->dev, iface_no, altno); } return 0; }