From: Ajay Singh Date: Thu, 16 Sep 2021 16:49:22 +0000 (+0000) Subject: wilc1000: use correct write command sequence in wilc_spi_sync_ext() X-Git-Tag: v6.6.17~8953^2~267^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=301cfbab09fdc068ee4a126fc1fa3bf4b1394217;p=platform%2Fkernel%2Flinux-rpi.git wilc1000: use correct write command sequence in wilc_spi_sync_ext() Instead of using double read for the same register, use the write register command after the read command. The correct sequence is to use the read value in write command instead of reading the same register again. Signed-off-by: Ajay Singh Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210916164902.74629-11-ajay.kathat@microchip.com --- diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c index 4f0bc24..640850f 100644 --- a/drivers/net/wireless/microchip/wilc1000/spi.c +++ b/drivers/net/wireless/microchip/wilc1000/spi.c @@ -1167,7 +1167,7 @@ static int wilc_spi_sync_ext(struct wilc *wilc, int nint) for (i = 0; (i < 3) && (nint > 0); i++, nint--) reg |= BIT(i); - ret = wilc_spi_read_reg(wilc, WILC_INTR2_ENABLE, ®); + ret = wilc_spi_write_reg(wilc, WILC_INTR2_ENABLE, reg); if (ret) { dev_err(&spi->dev, "Failed write reg (%08x)...\n", WILC_INTR2_ENABLE);