From: Neil Zhang Date: Thu, 9 Jan 2014 09:25:57 +0000 (+0800) Subject: gpio: pxa: clamp gpio get value to [0,1] X-Git-Tag: v4.14-rc1~8239^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3018fd81310688c3dfe8938a98680a9341982d02;p=platform%2Fkernel%2Flinux-rpi.git gpio: pxa: clamp gpio get value to [0,1] It would be convenient to normalize the return value for gpio_get. I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x. It's OK for all of them to change this function to return 0 and 1. Signed-off-by: Neil Zhang Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index cc13d1b74fad..42e6e64f2120 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -263,7 +263,8 @@ static int pxa_gpio_direction_output(struct gpio_chip *chip, static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset) { - return readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET) & (1 << offset); + u32 gplr = readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET); + return !!(gplr & (1 << offset)); } static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int value)