From: Cheoleun Moon Date: Tue, 18 May 2021 04:08:51 +0000 (+0900) Subject: Fix resource leak X-Git-Tag: submit/tizen/20210531.063738^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30166d4b98a934c25c34fcd5dd4cc4a3f4102498;p=platform%2Fcore%2Fapi%2Fwifi-aware.git Fix resource leak Change-Id: I003246ba0c893e580bb8ed50a0b9d3bc5f3f72f1 Signed-off-by: Cheoleun Moon --- diff --git a/src/wifi-aware-private.c b/src/wifi-aware-private.c index 300aa4e..146a579 100644 --- a/src/wifi-aware-private.c +++ b/src/wifi-aware-private.c @@ -344,8 +344,6 @@ static wifi_aware_error_e __get_dbus_result(GObject *src, GAsyncResult *res, uin int nan_error = 0; wifi_aware_error_e error = WIFI_AWARE_ERROR_NONE; - RET_VAL_IF(reply == NULL, WIFI_AWARE_ERROR_INVALID_OPERATION, "reply is NULL"); - if (dbus_error != NULL) { WIFI_AWARE_LOGE("Publish/Subsribe Request failure: %s", dbus_error->message); error = _wifi_aware_convert_error_string_to_enum(dbus_error->message); @@ -1293,7 +1291,6 @@ static void __send_message_reply(GObject *src, GAsyncResult *res, gpointer user_ conn = G_DBUS_CONNECTION(src); reply = g_dbus_connection_call_finish(conn, res, &dbus_error); - RET_IF(reply == NULL, "reply is NULL"); if (dbus_error != NULL) { WIFI_AWARE_LOGE("Followup Request failure: %s", dbus_error->message); @@ -1316,10 +1313,11 @@ int _wifi_aware_send_message(wifi_aware_session_h session, { __WIFI_AWARE_FUNC_ENTER__; RET_VAL_IF(session == NULL, WIFI_AWARE_ERROR_INVALID_PARAMETER, "wifi_aware_session_h is NULL"); + RET_VAL_IF(message == NULL, WIFI_AWARE_ERROR_INVALID_PARAMETER, "message is NULL"); uint16_t pub_sub_id = 0; wifi_aware_message_s *message_data = __create_message_data(session, callback, user_data); - RET_VAL_IF(message == NULL, WIFI_AWARE_ERROR_OUT_OF_MEMORY, "__create_cb_data fails"); + RET_VAL_IF(message_data == NULL, WIFI_AWARE_ERROR_OUT_OF_MEMORY, "__create_cb_data fails"); pub_sub_id = _wifi_aware_session_get_pub_sub_id(session);