From: xypron.glpk@gmx.de Date: Tue, 17 May 2016 22:06:02 +0000 (+0200) Subject: net: irda: avoid null pointer dereference X-Git-Tag: v5.15~13573^2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=30119059703f94e9e4936477bc33e918fb41e9c8;p=platform%2Fkernel%2Flinux-starfive.git net: irda: avoid null pointer dereference Only dereference variable self after checking it is not NULL. Signed-off-by: Heinrich Schuchardt Signed-off-by: David S. Miller --- diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c index 9ef13d8..aaecc3b 100644 --- a/drivers/net/irda/nsc-ircc.c +++ b/drivers/net/irda/nsc-ircc.c @@ -1253,7 +1253,7 @@ static void nsc_ircc_change_dongle_speed(int iobase, int speed, int dongle_id) */ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) { - struct net_device *dev = self->netdev; + struct net_device *dev; __u8 mcr = MCR_SIR; int iobase; __u8 bank; @@ -1263,6 +1263,7 @@ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) IRDA_ASSERT(self != NULL, return 0;); + dev = self->netdev; iobase = self->io.fir_base; /* Update accounting for new speed */