From: Rich Trott <rtrott@gmail.com>
Date: Tue, 17 Nov 2015 05:42:47 +0000 (-0800)
Subject: test: fix flaky test-child-process-spawnsync-input
X-Git-Tag: v4.2.4~42
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2fe6b45c2997bb8727dbaac2289539e296c999ad;p=platform%2Fupstream%2Fnodejs.git

test: fix flaky test-child-process-spawnsync-input

Move portion of `test-child-process-spawnsync-input.js` (that has been
flaky on CentOS in CI) to its own file. This allows us to more easily
eliminate the cause of the flakiness without affecting other unrelated
portions of the test.

Fixes: https://github.com/nodejs/node/issues/3863
PR-URL: https://github.com/nodejs/node/pull/3889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---

diff --git a/test/parallel/test-child-process-spawnsync-input.js b/test/parallel/test-child-process-spawnsync-input.js
index d978bd8..338b427 100644
--- a/test/parallel/test-child-process-spawnsync-input.js
+++ b/test/parallel/test-child-process-spawnsync-input.js
@@ -87,15 +87,3 @@ ret = spawnSync(process.execPath, args, { encoding: 'utf8' });
 checkSpawnSyncRet(ret);
 assert.strictEqual(ret.stdout, msgOut + '\n');
 assert.strictEqual(ret.stderr, msgErr + '\n');
-
-options = {
-  maxBuffer: 1
-};
-
-ret = spawnSync(process.execPath, args, options);
-
-assert.ok(ret.error, 'maxBuffer should error');
-assert.strictEqual(ret.error.errno, 'ENOBUFS');
-// we can have buffers larger than maxBuffer because underneath we alloc 64k
-// that matches our read sizes
-assert.deepEqual(ret.stdout, msgOutBuf);
diff --git a/test/parallel/test-child-process-spawnsync-maxbuf.js b/test/parallel/test-child-process-spawnsync-maxbuf.js
new file mode 100644
index 0000000..d8f286d
--- /dev/null
+++ b/test/parallel/test-child-process-spawnsync-maxbuf.js
@@ -0,0 +1,27 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+
+const spawnSync = require('child_process').spawnSync;
+
+const msgOut = 'this is stdout';
+
+// This is actually not os.EOL?
+const msgOutBuf = new Buffer(msgOut + '\n');
+
+const args = [
+  '-e',
+  `console.log("${msgOut}");`
+];
+
+const options = {
+  maxBuffer: 1
+};
+
+const ret = spawnSync(process.execPath, args, options);
+
+assert.ok(ret.error, 'maxBuffer should error');
+assert.strictEqual(ret.error.errno, 'ENOBUFS');
+// We can have buffers larger than maxBuffer because underneath we alloc 64k
+// that matches our read sizes
+assert.deepEqual(ret.stdout, msgOutBuf);