From: Junghyun Yeon <jungh.yeon@samsung.com>
Date: Fri, 17 Jan 2020 01:27:58 +0000 (+0900)
Subject: Resolve static analysis issue
X-Git-Tag: submit/tizen/20200117.084916~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2fb583de2527ee8e4a5fe5032b2a53fd80911a5b;p=platform%2Fcore%2Fappfw%2Ftpk-backend.git

Resolve static analysis issue

Change-Id: I0c532cc7ca55da09fcfc1bb661aa2b81387d2496
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
---

diff --git a/src/tpk/step/pkgmgr/step_convert_xml.cc b/src/tpk/step/pkgmgr/step_convert_xml.cc
index 20a399a..8f0be90 100644
--- a/src/tpk/step/pkgmgr/step_convert_xml.cc
+++ b/src/tpk/step/pkgmgr/step_convert_xml.cc
@@ -81,8 +81,12 @@ bool StepConvertXml::ConvertXml(xmlDocPtr doc) {
 
     expr = std::string(kXmlXPathAppExpr) + "[@appid='" + app->appid + "']";
     xpath_obj = xmlXPathEvalExpression((const xmlChar*)expr.c_str(), xpath_ctx);
-    if (!xpath_obj || !xpath_obj->nodesetval || !xpath_obj->nodesetval->nodeNr)
+    if (!xpath_obj || !xpath_obj->nodesetval ||
+        !xpath_obj->nodesetval->nodeNr) {
+      if (xpath_obj)
+        xmlXPathFreeObject(xpath_obj);
       continue;
+    }
 
     node = xpath_obj->nodesetval->nodeTab[0];
     xmlSetProp(node, kExecAttributeKey, (const xmlChar*)app->exec);
diff --git a/src/tpk/step/pkgmgr/step_manifest_adjustment.cc b/src/tpk/step/pkgmgr/step_manifest_adjustment.cc
index 327e503..091e745 100644
--- a/src/tpk/step/pkgmgr/step_manifest_adjustment.cc
+++ b/src/tpk/step/pkgmgr/step_manifest_adjustment.cc
@@ -159,6 +159,7 @@ common_installer::Step::Status StepManifestAdjustment::process() {
           xmlFreeDoc(doc);
           return Step::Status::ERROR;
         }
+        xmlXPathFreeObject(xpath_obj);
       }
       xmlXPathFreeContext(xpath_ctx);
     }