From: David Schleef Date: Wed, 29 Jun 2011 21:39:52 +0000 (-0700) Subject: jpegenc: Don't round up size of encoded buffers X-Git-Tag: 1.19.3~509^2~7136^2~474 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2f94df80325006fa72009e0c9d9e69b51e9ee3b5;p=platform%2Fupstream%2Fgstreamer.git jpegenc: Don't round up size of encoded buffers For some reason, in code dating to 2001, encoded jpeg buffers were rounded up to multiples of 4 bytes. With the added bonus that the extra bytes are unwritten, causing valgrind issues. Oops. I can't think of any reason why JPEG buffers need to be multiples of 4 bytes, so I removed the padding. There might be some code somewhere that depends on this behavior, so if this needs to be reverted, please fix the valgrind issues. --- diff --git a/ext/jpeg/gstjpegenc.c b/ext/jpeg/gstjpegenc.c index 8708a70..e631be6 100644 --- a/ext/jpeg/gstjpegenc.c +++ b/ext/jpeg/gstjpegenc.c @@ -246,8 +246,7 @@ gst_jpegenc_term_destination (j_compress_ptr cinfo) /* Trim the buffer size and push it. */ GST_BUFFER_SIZE (jpegenc->output_buffer) = - GST_ROUND_UP_4 (GST_BUFFER_SIZE (jpegenc->output_buffer) - - jpegenc->jdest.free_in_buffer); + GST_BUFFER_SIZE (jpegenc->output_buffer) - jpegenc->jdest.free_in_buffer; g_signal_emit (G_OBJECT (jpegenc), gst_jpegenc_signals[FRAME_ENCODED], 0);