From: dyamy-lee Date: Tue, 30 Jan 2024 09:39:31 +0000 (+0900) Subject: consider memory leak issue X-Git-Tag: accepted/tizen/unified/20240207.171607~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2f825471fcbd0f27eb40656c42e9d562389dd09d;p=platform%2Fcore%2Fuifw%2Ftts.git consider memory leak issue There is no case about temp->default_lang is not null. However, it couldn't sure that if the function's logic is changed. So, this added the free() for considering if temp->default_lang is not null case Change-Id: I226c248853301051c5444593d1297ef03a24ac98 --- diff --git a/server/ttsd_engine_agent.c b/server/ttsd_engine_agent.c index f6719cd7..1e3dd5f1 100644 --- a/server/ttsd_engine_agent.c +++ b/server/ttsd_engine_agent.c @@ -225,6 +225,9 @@ int ttsd_engine_agent_init(ttse_request_callback_s *callback) if (0 != ttsd_config_get_default_voice(&(temp->default_lang), &(temp->default_vctype))) { SLOG(LOG_WARN, tts_tag(), "[Server WARNING] There is No default voice in config"); /* Set default voice */ + if (temp->default_lang) { + free(temp->default_lang); + } temp->default_lang = strdup(TTS_BASE_LANGUAGE); temp->default_vctype = TTSE_VOICE_TYPE_FEMALE; }