From: Theodore Ts'o Date: Thu, 6 Jun 2013 15:16:43 +0000 (-0400) Subject: ext4: add sanity check to ext4_get_group_info() X-Git-Tag: accepted/tizen/common/20141203.182822~1813^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2f2e09eb15849562aede80ed007658e4504ded26;p=platform%2Fkernel%2Flinux-arm64.git ext4: add sanity check to ext4_get_group_info() The group number passed to ext4_get_group_info() should be valid, but let's add an assert to check this before we start creating a pointer based on that group number and dereferencing it. Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index bd9890f..f85f1fb 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2313,6 +2313,7 @@ struct ext4_group_info *ext4_get_group_info(struct super_block *sb, { struct ext4_group_info ***grp_info; long indexv, indexh; + BUG_ON(group >= EXT4_SB(sb)->s_groups_count); grp_info = EXT4_SB(sb)->s_group_info; indexv = group >> (EXT4_DESC_PER_BLOCK_BITS(sb)); indexh = group & ((EXT4_DESC_PER_BLOCK(sb)) - 1);